-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8338849: Update copyright header for files modified in 2024 #1543
Conversation
👋 Welcome back arapte! A progress list of the required criteria for merging this PR into |
@arapte This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for two media files. One definitely must be reverted (the legal file) and the other probably should be.
modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/src/prep_cif.c
Outdated
Show resolved
Hide resolved
Thanks Kevin, Reverted both the files. |
/integrate |
Going to push as commit fac1c2a. |
Update copyright year in files updated in year 2024.
This update is done specifically to update the year in webkit files, so that the webkit source shows no diff.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1543/head:pull/1543
$ git checkout pull/1543
Update a local copy of the PR:
$ git checkout pull/1543
$ git pull https://git.openjdk.org/jfx.git pull/1543/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1543
View PR using the GUI difftool:
$ git pr show -t 1543
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1543.diff
Webrev
Link to Webrev Comment