Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298728: Cells in VirtualFlow jump after resizing #149

Closed
wants to merge 1 commit into from

Conversation

jperedadnr
Copy link
Contributor

@jperedadnr jperedadnr commented Sep 5, 2023

Almost clean backport of 8298728: Cells in VirtualFlow jump after resizing
Reviewed-by: aghaisas, angorya

There was a small conflict in VirtualFlowTest::CellStub, due to JDK-8297414:

-        setSkin(new SkinStub<CellStub>(this));
+        setSkin(new SkinStub<>(this));

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298728: Cells in VirtualFlow jump after resizing (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx17u.git pull/149/head:pull/149
$ git checkout pull/149

Update a local copy of the PR:
$ git checkout pull/149
$ git pull https://git.openjdk.org/jfx17u.git pull/149/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 149

View PR using the GUI difftool:
$ git pr show -t 149

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx17u/pull/149.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 5, 2023

👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ca29cc6122010e4b94778cc658efd4fdddc8af67 8298728: Cells in VirtualFlow jump after resizing Sep 5, 2023
@openjdk
Copy link

openjdk bot commented Sep 5, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 5, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 5, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 5, 2023

@jperedadnr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298728: Cells in VirtualFlow jump after resizing

Reviewed-by: jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 5, 2023
@johanvos johanvos self-requested a review September 5, 2023 09:42
@jperedadnr
Copy link
Contributor Author

Tests are failing

@jperedadnr jperedadnr closed this Sep 5, 2023
@jperedadnr jperedadnr deleted the backport-ca29cc6 branch September 5, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ready Pull request is ready to be integrated rfr Pull request is ready for review
2 participants