8334657: Enable binary check

[johanvos]

Hi all,

This pull request contains a backport of commit 101e5175 from the openjdk/jfx repository.

The commit being backported was authored by Kevin Rushforth on 25 Jun 2024 and was reviewed by Ambarish Rapte and Phil Race.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8334657 needs maintainer approval
• JDK-8334656 needs maintainer approval

Issues

• JDK-8334657: Enable binary check (Bug - P3 - Approved)
• JDK-8334656: Enable issuestitle check (Bug - P4 - Approved)

Reviewers

• Jose Pereda (@jperedadnr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx17u.git pull/198/head:pull/198
$ git checkout pull/198

Update a local copy of the PR:
$ git checkout pull/198
$ git pull https://git.openjdk.org/jfx17u.git pull/198/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 198

View PR using the GUI difftool:
$ git pr show -t 198

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx17u/pull/198.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334657: Enable binary check
8334656: Enable issuestitle check

Reviewed-by: jpereda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issues from the original commit.

[mlbridge]

Webrevs

• 00: Full (7701393b)

[openjdk]

⚠️ @johanvos This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[johanvos]

/approval request

[openjdk]

@johanvos
8334657: The approval request has been created successfully.
8334656: The approval request has been created successfully.

[johanvos]

/integrate

[openjdk]

@johanvos This pull request has not yet been marked as ready for integration.

[johanvos]

/approve

[openjdk]

@johanvos usage: /approve [<id>] (yes|no)

[johanvos]

/approve yes

[openjdk]

@johanvos
8334657: The approval request has been approved.
8334656: The approval request has been approved.

[johanvos]

/integrate

[openjdk]

Going to push as commit 0eef854.

[openjdk]

@johanvos Pushed as commit 0eef854.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.