-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8331765: Websocket callbacks are not executed after WebKit 617.1 update #200
8331765: Websocket callbacks are not executed after WebKit 617.1 update #200
Conversation
👋 Welcome back schernyshev! A progress list of the required criteria for merging this PR into |
@sercher This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request |
/approve yes |
@johanvos |
/integrate |
/sponsor |
Hi all,
Please review a clean backport of 6a586b66 from the openjdk/jfx repository.
The commit being backported was authored by @theaoqi on 27 Jun 2024 and was reviewed by @kevinrushforth and @HimaBinduMeda. This is part of the prerequisites for backporting WebKit 619.1 to OpenJFX 17.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx17u.git pull/200/head:pull/200
$ git checkout pull/200
Update a local copy of the PR:
$ git checkout pull/200
$ git pull https://git.openjdk.org/jfx17u.git pull/200/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 200
View PR using the GUI difftool:
$ git pr show -t 200
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx17u/pull/200.diff
Webrev
Link to Webrev Comment