Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347937: Canvas pattern test fails and crashes on WebKit 620.1 #16

Conversation

jaybhaskar
Copy link
Member

@jaybhaskar jaybhaskar commented Mar 24, 2025

A clean backport to jfx24u , the patch fixes current canvas pattern issue where canvas pattern drawing was not working when using svg matrix image.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8347937 needs maintainer approval

Issue

  • JDK-8347937: Canvas pattern test fails and crashes on WebKit 620.1 (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx24u.git pull/16/head:pull/16
$ git checkout pull/16

Update a local copy of the PR:
$ git checkout pull/16
$ git pull https://git.openjdk.org/jfx24u.git pull/16/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16

View PR using the GUI difftool:
$ git pr show -t 16

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx24u/pull/16.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 24, 2025

👋 Welcome back jbhaskar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@jaybhaskar
Copy link
Member Author

/approval request Important follow-on fix for canvas pattern issue

@openjdk
Copy link

openjdk bot commented Mar 24, 2025

@jaybhaskar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347937: Canvas pattern test fails and crashes on WebKit 620.1

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport fd099a7f067c1694c1c12a8fa02b1e7eda51201f 8347937: Canvas pattern test fails and crashes on WebKit 620.1 Mar 24, 2025
@openjdk
Copy link

openjdk bot commented Mar 24, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 24, 2025

⚠️ @jaybhaskar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 24, 2025
@openjdk
Copy link

openjdk bot commented Mar 24, 2025

@jaybhaskar
8347937: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 24, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 24, 2025

Webrevs

@kevinrushforth
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Mar 24, 2025

@kevinrushforth
8347937: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 24, 2025
@jaybhaskar
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 24, 2025

Going to push as commit 1ea359b.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 24, 2025
@openjdk openjdk bot closed this Mar 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 24, 2025
@openjdk
Copy link

openjdk bot commented Mar 24, 2025

@jaybhaskar Pushed as commit 1ea359b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants