7263: JMC displaying long value in scientific notation #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
e1iu
reviewed
Apr 3, 2024
| @@ -44,4 +44,5 @@ public final class JfrInternalConstants { | |||
| public static final String BCI_ID = "bytecodeIndex"; //$NON-NLS-1$ | |||
| public static final String MODIFIERS_ID = "modifiers"; //$NON-NLS-1$ | |||
| public static final String JAVA_THREAD_ID_ID = "javaThreadId"; //$NON-NLS-1$ | |||
| public static final String CERTIFICATE_ID = "certificateId"; //$NON-NLS-1$ | |||
|
@Suchitainf This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the formatting issue for the certificate Ids for X509 Certificate events.
Before the fix:
After the fix:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/559/head:pull/559$ git checkout pull/559Update a local copy of the PR:
$ git checkout pull/559$ git pull https://git.openjdk.org/jmc.git pull/559/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 559View PR using the GUI difftool:
$ git pr show -t 559Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/559.diff
Webrev
Link to Webrev Comment