-
Notifications
You must be signed in to change notification settings - Fork 175
8303: NPE at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport #616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rt.addReport
👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into |
@Suchitainf This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
...recorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/report/JfrRulesReport.java
Outdated
Show resolved
Hide resolved
....openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkQueries.java
Show resolved
Hide resolved
Webrevs
|
/integrate |
Going to push as commit 77713a0. |
@Suchitainf Pushed as commit 77713a0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
One of our customers is trying to generate XML report using below mentioned command.
java -cp ".\common-9.1.0-SNAPSHOT.jar;.\flightrecorder-9.1.0-SNAPSHOT.jar;.\flightrecorder.rules-9.1.0-SNAPSHOT.jar;.\flightrecorder.rules.jdk-9.1.0-SNAPSHOT.jar;.\lz4-java_1.8.0.jar;.\org.owasp.encoder_1.2.3.jar" org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport JFRFileName.jfr -verbose -format xml > XmlFileName.xml
The report is not generated and the console is showing NullPointerException as below:
Caused by: java.lang.NullPointerException: Cannot invoke "org.openjdk.jmc.common.item.IMemberAccessor.getMember(Object)" because "a" is null
at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport(JfrRulesReport.java:331)
at com.oracle.psr.pcl.analyzers.jmc.JMCParserProcess.call(JMCParserProcess.java:82)
at com.oracle.psr.pcl.analyzers.jmc.JMCParserProcess.call(JMCParserProcess.java:36)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:842)
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/616/head:pull/616
$ git checkout pull/616
Update a local copy of the PR:
$ git checkout pull/616
$ git pull https://git.openjdk.org/jmc.git pull/616/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 616
View PR using the GUI difftool:
$ git pr show -t 616
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/616.diff
Using Webrev
Link to Webrev Comment