Skip to content

8303: NPE at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

Suchitainf
Copy link
Collaborator

@Suchitainf Suchitainf commented Dec 12, 2024

One of our customers is trying to generate XML report using below mentioned command.

java -cp ".\common-9.1.0-SNAPSHOT.jar;.\flightrecorder-9.1.0-SNAPSHOT.jar;.\flightrecorder.rules-9.1.0-SNAPSHOT.jar;.\flightrecorder.rules.jdk-9.1.0-SNAPSHOT.jar;.\lz4-java_1.8.0.jar;.\org.owasp.encoder_1.2.3.jar" org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport JFRFileName.jfr -verbose -format xml > XmlFileName.xml

The report is not generated and the console is showing NullPointerException as below:

Caused by: java.lang.NullPointerException: Cannot invoke "org.openjdk.jmc.common.item.IMemberAccessor.getMember(Object)" because "a" is null
at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport(JfrRulesReport.java:331)
at com.oracle.psr.pcl.analyzers.jmc.JMCParserProcess.call(JMCParserProcess.java:82)
at com.oracle.psr.pcl.analyzers.jmc.JMCParserProcess.call(JMCParserProcess.java:36)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:842) 


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8303: NPE at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/616/head:pull/616
$ git checkout pull/616

Update a local copy of the PR:
$ git checkout pull/616
$ git pull https://git.openjdk.org/jmc.git pull/616/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 616

View PR using the GUI difftool:
$ git pr show -t 616

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/616.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

…rt.addReport
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2024

👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 12, 2024

@Suchitainf This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303: NPE at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr label Dec 12, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2024

Webrevs

@thegreystone thegreystone self-requested a review December 12, 2024 22:50

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@openjdk openjdk bot added the ready label Dec 18, 2024
@Suchitainf
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 19, 2024

Going to push as commit 77713a0.

@openjdk openjdk bot added the integrated label Dec 19, 2024
@openjdk openjdk bot closed this Dec 19, 2024
@openjdk
Copy link

openjdk bot commented Dec 19, 2024

@Suchitainf Pushed as commit 77713a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants