CODETOOLS-7903501: JOL: Reformat heapdump-estimates output #42
+371
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heapdump-estimates is a very useful tool to select a proper JVM mode, based on heap dump of live objects. We can make it much more human-readable.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jol.git pull/42/head:pull/42
$ git checkout pull/42
Update a local copy of the PR:
$ git checkout pull/42
$ git pull https://git.openjdk.org/jol.git pull/42/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 42
View PR using the GUI difftool:
$ git pr show -t 42
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jol/pull/42.diff
Webrev
Link to Webrev Comment