7903765: wget failed in build.sh in jtreg

[jaikiran]

Can I get a review of this change which proposes to address the issue noted in https://bugs.openjdk.org/browse/CODETOOLS-7903765? This is an alternative approach that we decided to take when reviewing the original PR for this issue #211.

In this change, when passing destination directories for downloading source archives of asmtools and jtharness, we pass the absolute path instead of paths containing relative path elements (like ../). This change prevents wget running into an issue when dealing with destination directories containing ../ path element.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• CODETOOLS-7903765: wget failed in build.sh in jtreg (Bug - P4)

Reviewers

• Jonathan Gibbons (@jonathan-gibbons - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/214/head:pull/214
$ git checkout pull/214

Update a local copy of the PR:
$ git checkout pull/214
$ git pull https://git.openjdk.org/jtreg.git pull/214/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 214

View PR using the GUI difftool:
$ git pr show -t 214

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/214.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7903765: wget failed in build.sh in jtreg

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• feee504: 7903784: NullPointerException: Cannot read the array length because the return value of "java.io.File.listFiles()" is null
• a9172d6: 7903759: Amend changelog to include the removal of jtdiff

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (593d6c46)

[jaikiran]

Thank you Jon for the review.

[jaikiran]

/integrate

[openjdk]

Going to push as commit ca8c1ec.
Since your change was applied there have been 2 commits pushed to the master branch:

• feee504: 7903784: NullPointerException: Cannot read the array length because the return value of "java.io.File.listFiles()" is null
• a9172d6: 7903759: Amend changelog to include the removal of jtdiff

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit ca8c1ec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.