7903872: Option testThreadFactoryPath support relativepath

[sendaoYan]

Hi all,
Currently, the jtreg option -testThreadFactoryPath doesn't support relativepath.
I think jtreg can support relativepath for option -testThreadFactoryPath, same like to -jdk or -nativepath.
Change has been verified locally, risk is low.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• CODETOOLS-7903872: Option testThreadFactoryPath support relativepath (Enhancement - P4)

Reviewers

• Christian Stein (@sormuras - Committer)
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/233/head:pull/233
$ git checkout pull/233

Update a local copy of the PR:
$ git checkout pull/233
$ git pull https://git.openjdk.org/jtreg.git pull/233/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 233

View PR using the GUI difftool:
$ git pr show -t 233

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/233.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7903872: Option testThreadFactoryPath support relativepath

Reviewed-by: cstein, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 857ed61: 7903193: [jtreg] build and test failures using JDK 18

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sormuras, @jaikiran) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 02: Full - Incremental (193923a4)
• 01: Full - Incremental (3e1115e7)
• 00: Full (0351e462)

[sormuras]

Do you know why the void setTestThreadFactoryPath(String testThreadFactoryPath) doesn't get a similar split/parsing treatment as setTimeoutHandlerPath(String timeoutHandlerPath) ?

jtreg/src/share/classes/com/sun/javatest/regtest/config/RegressionParameters.java

Lines 1243 to 1251 in cf42c7c

	void setTimeoutHandlerPath(String timeoutHandlerPath) {
	Objects.requireNonNull(timeoutHandlerPath);
	this.timeoutHandlerPath = new ArrayList<>();
	for (String f: timeoutHandlerPath.split(File.pathSeparator)) {
	if (f.length() > 0) {
	this.timeoutHandlerPath.add(Path.of(f));
	}
	}
	}

[sormuras]

Thanks for the update to use NIO API.

Please also extend the existing test in https://github.com/openjdk/jtreg/tree/master/test/testThreadFactory to use both kinds of paths: one absolute path and one relative path.

[sendaoYan]

Please also extend the existing test in https://github.com/openjdk/jtreg/tree/master/test/testThreadFactory to use both kinds of paths: one absolute path and one relative path.

TestThreadFactoryRelativePath has been added for test the relative path. The test has been verified locally.

bash build/make.sh $(pwd)/build/test/TestThreadFactoryRelativePath.ok $(pwd)/build/test/TestThreadFactoryAbsolutePath.ok
find build/test/ -name "*.ok" | xargs cat

[sendaoYan]

GHA report failure gzip: stdin: not in gzip format at Installed distributions stage, seems like github action issue.

[bridgekeeper]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

/open

[openjdk]

@sendaoYan This pull request is already open

[sormuras]

Looks good to me.

[jaikiran]

This looks good to me. I haven't had a chance to run the test myself. Please verify that this updated test as well as existing tests continue to pass, before integrating.

[sendaoYan]

Thanks all for the review.

The newly added tests and the existing tests run passed locally.

/integrate

[openjdk]

@sendaoYan
Your change (at version 193923a) is now ready to be sponsored by a Committer.

[jaikiran]

/sponsor

[openjdk]

Going to push as commit 8e74d55.
Since your change was applied there has been 1 commit pushed to the master branch:

• 857ed61: 7903193: [jtreg] build and test failures using JDK 18

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran @sendaoYan Pushed as commit 8e74d55.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[sendaoYan]

Thanks for the sponsor.