Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903962: Update IDEA plugin documentation #247

Conversation

asilichenko
Copy link
Contributor

@asilichenko asilichenko commented Feb 6, 2025

Update menu item location to open default settings window.

Current location is: File -> New Projects Setup -> Settings for New Projects...

Checked in "IntelliJ IDEA 2024.3.2.2 (Community Edition)".

Default settings menu location


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/247/head:pull/247
$ git checkout pull/247

Update a local copy of the PR:
$ git checkout pull/247
$ git pull https://git.openjdk.org/jtreg.git pull/247/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 247

View PR using the GUI difftool:
$ git pr show -t 247

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/247.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 6, 2025

👋 Welcome back asilichenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 6, 2025

@asilichenko This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7903962: Update IDEA plugin documentation

Reviewed-by: jvernee, cstein

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 759946d: 7903953: Use scratch directory for JUnit's TempDir annotation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JornVernee, @sormuras) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@asilichenko asilichenko closed this Mar 4, 2025
@asilichenko asilichenko deleted the idea-plugin-update-readme-default-settings branch March 4, 2025 16:43
@asilichenko asilichenko restored the idea-plugin-update-readme-default-settings branch March 6, 2025 13:48
@asilichenko asilichenko reopened this Mar 6, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 6, 2025

@asilichenko This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@JornVernee
Copy link
Member

When I try this, I now see the jtreg settings under the 'Other Settings' tab:
image

I think this would also be useful to mention in the docs.

@JornVernee
Copy link
Member

I've created https://bugs.openjdk.org/browse/CODETOOLS-7903962, Please change the title of the PR to:

7903962: Update IDEA plugin documentation

@asilichenko asilichenko changed the title Update IDEA plugin documentation 7903962: Update IDEA plugin documentation Mar 7, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 7, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 7, 2025

Webrevs

@asilichenko asilichenko force-pushed the idea-plugin-update-readme-default-settings branch from 05f0fd2 to 6380598 Compare March 7, 2025 15:57
Update menu item location to open default settings window.
@asilichenko asilichenko force-pushed the idea-plugin-update-readme-default-settings branch from 6380598 to 67cdbe0 Compare March 7, 2025 16:03
@openjdk
Copy link

openjdk bot commented Mar 7, 2025

@asilichenko Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

- insert "-" into "drop-down"
- remove doubled "the"
- add a mention of 'Other Settings' to the New Projects Settings section
@asilichenko
Copy link
Contributor Author

@JornVernee, thank you for creating the issue. I have added a mention about 'Other Settings'.

@JornVernee
Copy link
Member

I have asked someone with the Reviewer role in the code tools project to take a look as well, as I can not give final approval.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 7, 2025
@JornVernee
Copy link
Member

This PR is ready to be merged now. See the comment here for the instructions: #247 (comment)

@asilichenko
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 7, 2025
@openjdk
Copy link

openjdk bot commented Mar 7, 2025

@asilichenko
Your change (at version 16ab82d) is now ready to be sponsored by a Committer.

@sormuras
Copy link
Member

sormuras commented Mar 8, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 8, 2025

Going to push as commit 03c2ac6.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 759946d: 7903953: Use scratch directory for JUnit's TempDir annotation

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 8, 2025
@openjdk openjdk bot closed this Mar 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 8, 2025
@openjdk
Copy link

openjdk bot commented Mar 8, 2025

@sormuras @asilichenko Pushed as commit 03c2ac6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@asilichenko asilichenko deleted the idea-plugin-update-readme-default-settings branch March 10, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants