-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7903962: Update IDEA plugin documentation #247
7903962: Update IDEA plugin documentation #247
Conversation
👋 Welcome back asilichenko! A progress list of the required criteria for merging this PR into |
@asilichenko This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JornVernee, @sormuras) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@asilichenko This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
I've created https://bugs.openjdk.org/browse/CODETOOLS-7903962, Please change the title of the PR to:
|
Webrevs
|
05f0fd2
to
6380598
Compare
Update menu item location to open default settings window.
6380598
to
67cdbe0
Compare
@asilichenko Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
- insert "-" into "drop-down" - remove doubled "the" - add a mention of 'Other Settings' to the New Projects Settings section
@JornVernee, thank you for creating the issue. I have added a mention about 'Other Settings'. |
I have asked someone with the Reviewer role in the code tools project to take a look as well, as I can not give final approval. |
This PR is ready to be merged now. See the comment here for the instructions: #247 (comment) |
/integrate |
@asilichenko |
/sponsor |
@sormuras @asilichenko Pushed as commit 03c2ac6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Update menu item location to open default settings window.
Current location is:
File -> New Projects Setup -> Settings for New Projects...
Checked in "IntelliJ IDEA 2024.3.2.2 (Community Edition)".
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/247/head:pull/247
$ git checkout pull/247
Update a local copy of the PR:
$ git checkout pull/247
$ git pull https://git.openjdk.org/jtreg.git pull/247/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 247
View PR using the GUI difftool:
$ git pr show -t 247
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/247.diff
Using Webrev
Link to Webrev Comment