-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RISC-V vthread support for JVM intrinsic monitors #212
Conversation
👋 Welcome back fyang! A progress list of the required criteria for merging this PR into |
@RealFYang This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@pchilano) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
Nice work! |
Great! I see test jdk/java/lang/Thread/virtual/Parking.java should also have os.arch=="riscv64" added. |
Thanks for finding this! Seems that I missed this test somehow. Added and tested with both release and fastdebug builds on linux-riscv64. |
Thanks for the update. Once all ports that support VMContinuations are aligned then I think we can drop this |
Great, thanks @RealFYang! |
@RealFYang If you "/integrate" then we should be able to sponsor. |
All right. Let's get this integrated. Thanks everyone for having a look. |
@RealFYang |
/sponsor |
Going to push as commit 5a3deae. |
@AlanBateman @RealFYang Pushed as commit 5a3deae. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This ported vthread support for JVM intrinsic monitors to linux-riscv64 platform.
Testing on linux-riscv64:
Progress
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/loom.git pull/212/head:pull/212
$ git checkout pull/212
Update a local copy of the PR:
$ git checkout pull/212
$ git pull https://git.openjdk.org/loom.git pull/212/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 212
View PR using the GUI difftool:
$ git pr show -t 212
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/loom/pull/212.diff
Webrev
Link to Webrev Comment