Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8305170: Add MemoryLayout::withoutAlignment as an alias for withAlignment(8) #852

Closed

Conversation

minborg
Copy link
Collaborator

@minborg minborg commented Jul 27, 2023

This PR proposes to add new methods to the many MemoryLayout classes called withoutAlignment() and that is an alias of calling withAlignment(1).


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8305170: Add MemoryLayout::withoutAlignment as an alias for withAlignment(8) (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/panama-foreign.git pull/852/head:pull/852
$ git checkout pull/852

Update a local copy of the PR:
$ git checkout pull/852
$ git pull https://git.openjdk.org/panama-foreign.git pull/852/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 852

View PR using the GUI difftool:
$ git pr show -t 852

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/panama-foreign/pull/852.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 27, 2023

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into foreign-memaccess+abi will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Jul 27, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 27, 2023

Webrevs

@mcimadamore
Copy link
Collaborator

Honestly, I don't see this as being a necessary addition.

@minborg
Copy link
Collaborator Author

minborg commented Jul 27, 2023

I will close this PR as the cost/benefit does not merit the change.

@minborg minborg closed this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Ready for review
2 participants