Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misc typos in FFM API javadoc #873

Closed

Conversation

mcimadamore
Copy link
Collaborator

@mcimadamore mcimadamore commented Aug 21, 2023

This PR fixes a bunch of issues found when running grammar code inspection in IntelliJ.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/panama-foreign.git pull/873/head:pull/873
$ git checkout pull/873

Update a local copy of the PR:
$ git checkout pull/873
$ git pull https://git.openjdk.org/panama-foreign.git pull/873/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 873

View PR using the GUI difftool:
$ git pr show -t 873

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/panama-foreign/pull/873.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2023

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into foreign-memaccess+abi will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Aug 21, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mlbridge
Copy link

mlbridge bot commented Aug 21, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 4, 2023

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Fix misc typos in FFM API javadoc

Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the foreign-memaccess+abi branch:

  • 9c33344: Add missing @implSpec to AddressLayout
  • 9a4515c: 8315096: Allowed access modes in memory segment should depend on layout alignment
  • 7c46965: 8315041: Optimize Java to C string conversion by avoiding double copy
  • e00e7d6: Benchmark Java to/from C string conversions

Please see this link for an up-to-date comparison between the source branch of this pull request and the foreign-memaccess+abi branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-memaccess+abi branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Sep 4, 2023
@mcimadamore
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 4, 2023

Going to push as commit 4473ef2.
Since your change was applied there have been 4 commits pushed to the foreign-memaccess+abi branch:

  • 9c33344: Add missing @implSpec to AddressLayout
  • 9a4515c: 8315096: Allowed access modes in memory segment should depend on layout alignment
  • 7c46965: 8315041: Optimize Java to C string conversion by avoiding double copy
  • e00e7d6: Benchmark Java to/from C string conversions

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 4, 2023
@openjdk openjdk bot closed this Sep 4, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Sep 4, 2023
@openjdk
Copy link

openjdk bot commented Sep 4, 2023

@mcimadamore Pushed as commit 4473ef2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants