Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports #888

Conversation

minborg
Copy link
Collaborator

@minborg minborg commented Sep 22, 2023

This PR proposes to remove a number of unused imports in the implementation classes.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/panama-foreign.git pull/888/head:pull/888
$ git checkout pull/888

Update a local copy of the PR:
$ git checkout pull/888
$ git pull https://git.openjdk.org/panama-foreign.git pull/888/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 888

View PR using the GUI difftool:
$ git pr show -t 888

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/panama-foreign/pull/888.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
minborg Per-Ake Minborg
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2023

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into foreign-memaccess+abi will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Sep 22, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 22, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@minborg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Remove unused imports

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the foreign-memaccess+abi branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-memaccess+abi branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Sep 22, 2023
@minborg
Copy link
Collaborator Author

minborg commented Sep 22, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 22, 2023

Going to push as commit 3d02255.
Since your change was applied there have been 112 commits pushed to the foreign-memaccess+abi branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 22, 2023
@openjdk openjdk bot closed this Sep 22, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@minborg Pushed as commit 3d02255.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants