-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8328580: Remove trivial shared code changes which are leftover from riscv port #12
Conversation
👋 Welcome back gcao! A progress list of the required criteria for merging this PR into |
@zifeihan This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@andreas-schwab : Hi, Could you please take a look? |
Looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial. Thanks.
@andreas-schwab @RealFYang : Thanks all for the review. |
/sponsor |
Going to push as commit 46d18f6. |
@RealFYang @zifeihan Pushed as commit 46d18f6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi, This patch used to remove trivial shared code changes which are leftover from riscv port, here are some related discussions #11 (comment). just a few changes to copyright date and spurious space.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/12/head:pull/12
$ git checkout pull/12
Update a local copy of the PR:
$ git checkout pull/12
$ git pull https://git.openjdk.org/riscv-port-jdk11u.git pull/12/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12
View PR using the GUI difftool:
$ git pr show -t 12
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk11u/pull/12.diff
Webrev
Link to Webrev Comment