Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops #22

Closed
wants to merge 1 commit into from

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Apr 15, 2024

Hi,
Please help review this backport to riscv-port-jdk11u.
Backport of JDK-8294087.
The original patch cannot be directly applied because of riscv-port-jdk11u do not have emit_entry_barrier_stub C2CodeStub and no JDK-8216557.

Testing

  • Run tier1-tier3 tests on SOPHON SG2042 (fastdebug)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/22/head:pull/22
$ git checkout pull/22

Update a local copy of the PR:
$ git checkout pull/22
$ git pull https://git.openjdk.org/riscv-port-jdk11u.git pull/22/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22

View PR using the GUI difftool:
$ git pr show -t 22

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk11u/pull/22.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 15, 2024

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 15, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport a216960d71bdf111a9c232a0228cc43256a01b29 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops Apr 15, 2024
@openjdk
Copy link

openjdk bot commented Apr 15, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Apr 15, 2024
@zifeihan zifeihan force-pushed the backport-JDK-8294087 branch from cc8da21 to 3e80e8e Compare April 15, 2024 11:18
…d more alignment assertions for the patchable calls/nops
@zifeihan zifeihan force-pushed the backport-JDK-8294087 branch from 3e80e8e to a725163 Compare April 16, 2024 10:01
@zifeihan zifeihan marked this pull request as ready for review April 18, 2024 07:48
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 18, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 18, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented May 16, 2024

@zifeihan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 13, 2024

@zifeihan This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

None yet

1 participant