8308277: RISC-V: Improve vectorization of Match.sqrt() on floats

[feilongjiang]

Hi,
Please review this clean backport of JDK-8308277.

For jdk17u, Math.sqrt(float) will not get vectorized even when UseRVV is true without the SqrtF node.

Here is the OptoAssembly of Sqrt.java from JDK-8190800:

before:

120     B14: #  out( B14 B15 ) <- in( B13 B14 ) Loop( B14-B14 inner main of N91 strip mined) Freq: 1.86254e+07
120 +   addw  R28, R12, zr  #@convI2L_reg_reg
124 +   slli  R28, R28, (#2 & 0x3f) #@lShiftL_reg_imm
128 +   add R28, R18, R28   # ptr, #@addP_reg_reg
12c +   flw  F0, [R28, #16] # float, #@loadF
130 +   fsqrt.s  F1, F0 #@sqrtF_reg
134 +   fsw  F1, [R28, #16] # float, #@storeF

after:

140     B14: #  out( B14 B15 ) <- in( B13 B14 ) Loop( B14-B14 inner main of N93 strip mined) Freq: 1.60517e+07
140     addw  R10, R31, zr  #@convI2L_reg_reg
144     slli  R10, R10, (#2 & 0x3f) #@lShiftL_reg_imm
148     add R11, R9, R10    # ptr, #@addP_reg_reg
14c     addi  R10, R11, #16 # ptr, #@addP_reg_imm
150     vle V1, [R10]   #@loadV
158     vfsqrt.v V1, V1 #@vsqrtF
160     addi  R10, R11, #16 # ptr, #@addP_reg_imm
164     vse V1, [R10]   #@storeV

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8308277: RISC-V: Improve vectorization of Match.sqrt() on floats

Reviewers

• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/58/head:pull/58
$ git checkout pull/58

Update a local copy of the PR:
$ git checkout pull/58
$ git pull https://git.openjdk.org/riscv-port-jdk17u.git pull/58/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 58

View PR using the GUI difftool:
$ git pr show -t 58

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/58.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308277: RISC-V: Improve vectorization of Match.sqrt() on floats

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the riscv-port branch:

• 3e56225: Merge remote-tracking branch 'origin/master' into riscv-port
• 464a32b: 8227060: Optimize safepoint cleanup subtask order
• 6033871: 8306640: Open source several AWT TextArea related tests
• 05b2ff4: 8308554: [17u] Fix commit of 8286191. vm.musl was not removed from ExternalEditorTest
• 9c0afc5: 8306752: Open source several container and component AWT tests
• 4caa421: 8306755: Open source few Swing JComponent and AbstractButton tests
• b5d3772: 8306683: Open source several clipboard and color AWT tests
• 09e6880: 8306652: Open source AWT MenuItem related tests
• 18ec008: 8306409: Open source AWT KeyBoardFocusManger, LightWeightComponent related tests
• 536e133: 8306850: Open source AWT Modal related tests
• ... and 25 more: https://git.openjdk.org/riscv-port-jdk17u/compare/9207935f826ddc01176a88c0bf6341bc71a9d1bb...riscv-port

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (c8a21b0d)

[RealFYang]

I think it's OK to backport this so that we are on-par with other CPUs like aarch64.

[feilongjiang]

tier1 looks good.
/integrate

[openjdk]

@feilongjiang
Your change (at version c8a21b0) is now ready to be sponsored by a Committer.

[RealFYang]

/sponsor

[openjdk]

Going to push as commit 42f752d.
Since your change was applied there have been 35 commits pushed to the riscv-port branch:

• 3e56225: Merge remote-tracking branch 'origin/master' into riscv-port
• 464a32b: 8227060: Optimize safepoint cleanup subtask order
• 6033871: 8306640: Open source several AWT TextArea related tests
• 05b2ff4: 8308554: [17u] Fix commit of 8286191. vm.musl was not removed from ExternalEditorTest
• 9c0afc5: 8306752: Open source several container and component AWT tests
• 4caa421: 8306755: Open source few Swing JComponent and AbstractButton tests
• b5d3772: 8306683: Open source several clipboard and color AWT tests
• 09e6880: 8306652: Open source AWT MenuItem related tests
• 18ec008: 8306409: Open source AWT KeyBoardFocusManger, LightWeightComponent related tests
• 536e133: 8306850: Open source AWT Modal related tests
• ... and 25 more: https://git.openjdk.org/riscv-port-jdk17u/compare/9207935f826ddc01176a88c0bf6341bc71a9d1bb...riscv-port

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang @feilongjiang Pushed as commit 42f752d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.