Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8339197: GenShen: Adding Generation and Evacuation Information JFR Logging #81

Conversation

kdnilsen
Copy link
Contributor

@kdnilsen kdnilsen commented Sep 13, 2024

This pull request contains a backport of commit 662d146d from the openjdk/shenandoah repository.

The commit being backported was authored by Satyen Subramaniam on 4 Sep 2024 and was reviewed by Kelvin Nilsen,
William Kemper and Y. Srinivas Ramakrishna.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8339197: GenShen: Adding Generation and Evacuation Information JFR Logging (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah-jdk21u.git pull/81/head:pull/81
$ git checkout pull/81

Update a local copy of the PR:
$ git checkout pull/81
$ git pull https://git.openjdk.org/shenandoah-jdk21u.git pull/81/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 81

View PR using the GUI difftool:
$ git pr show -t 81

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/shenandoah-jdk21u/pull/81.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 13, 2024

👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 13, 2024

@kdnilsen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339197: GenShen: Adding Generation and Evacuation Information JFR Logging

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 662d146d52dd77d13cfe705a4a4959c5fb2fb5a1 8339197: GenShen: Adding Generation and Evacuation Information JFR Logging Sep 13, 2024
@openjdk
Copy link

openjdk bot commented Sep 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 13, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 13, 2024

Webrevs

@kdnilsen
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 16, 2024

Going to push as commit ef76022.
Since your change was applied there have been 10 commits pushed to the master branch:

  • c0b27b2: 8339611: GenShen: Simplify ShenandoahOldHeuristics::trigger_collection_if_fragmented
  • fe42b40: 8338717: GenShen: Fix up some assertions
  • a38c7c5: 8338620: GenShen: Distinguish between young and old collector in GC configuration
  • 3c8cffb: 8338528: GenShen: Cleanup shenandoahHeapRegion
  • 77cb7a3: 8338535: GenShen: some style improvements to source code implementation
  • cb900e8: 8338477: GenShen: Cleanup generational heap
  • fe6aec1: 8338479: GenShen: Detemplatize ShenandoahScanRemembered
  • eaffb30: 8338473: GenShen: Cleanup access levels, whitespace, typos and unused code
  • 1eee920: 8338420: GenShen: Forward declare card table for Shenandoah barrier set
  • 97ca83b: 8338336: GenShen: Cleanup stale TODOs

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 16, 2024
@openjdk openjdk bot closed this Sep 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2024
@openjdk
Copy link

openjdk bot commented Sep 16, 2024

@kdnilsen Pushed as commit ef76022.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

earthling-amzn pushed a commit to earthling-amzn/shenandoah-jdk21u that referenced this pull request Dec 19, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

1 participant