Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of new product flags #251

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Apr 11, 2023

Eventual upstreaming would require a CSR for every changed product flag. Not every flag we have now needs to be product, we can reduce them to be experimental.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/251/head:pull/251
$ git checkout pull/251

Update a local copy of the PR:
$ git checkout pull/251
$ git pull https://git.openjdk.org/shenandoah.git pull/251/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 251

View PR using the GUI difftool:
$ git pr show -t 251

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/251.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 11, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 11, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 11, 2023

Webrevs

Copy link
Member

@ysramakrishna ysramakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I suppose this doesn't preclude making them product in the future should the need arise.

Reviewed!

@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 12, 2023

@shipilev This pull request has not yet been marked as ready for integration.

Copy link
Collaborator

@rkennke rkennke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@openjdk
Copy link

openjdk bot commented Apr 13, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Reduce the number of new product flags

Reviewed-by: ysr, rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 9f256a5: Cleanups, TODOs, asserts (part 2)
  • 9d87724: Restore event descriptions immortality

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 13, 2023
@shipilev
Copy link
Member Author

Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented Apr 13, 2023

Going to push as commit b262350.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 9f256a5: Cleanups, TODOs, asserts (part 2)
  • 9d87724: Restore event descriptions immortality

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 13, 2023
@openjdk openjdk bot closed this Apr 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 13, 2023
@openjdk
Copy link

openjdk bot commented Apr 13, 2023

@shipilev Pushed as commit b262350.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the reduce-flags branch April 13, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants