Usage tracking cleanup

[earthling-amzn]

There are many nuances to tracing memory utilization. Shenandoah track's usage, waste by humongous objects, padding for promotion LABs alignment and all this is also tracked by generation, the heap and feeds into the heuristics and the pacer. The code to update all of these values and route them to the right places was spread across the allocation call stack. This change consolidates all of the logic into one method, invoked near the end of the allocation.

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Reviewers

• Kelvin Nilsen (@kdnilsen - Committer) ⚠️ Review applies to 0e49f914
• Y. Srinivas Ramakrishna (@ysramakrishna - Author) ⚠️ Review applies to 99c52914

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/260/head:pull/260
$ git checkout pull/260

Update a local copy of the PR:
$ git checkout pull/260
$ git pull https://git.openjdk.org/shenandoah.git pull/260/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 260

View PR using the GUI difftool:
$ git pr show -t 260

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/260.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 06: Full - Incremental (5cadad1a)
• 05: Full - Incremental (ca1e79f6)
• 04: Full (31003e80)
• 03: Full - Incremental (3f309b3a)
• 02: Full - Incremental (0303988c)
• 01: Full (99c52914)
• 00: Full (0e49f914)

[kdnilsen]

This looks like a good improvement. Thanks for sorting through these details. I assume we pass all the existing GenShen regression tests.

[openjdk]

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Usage tracking cleanup

Reviewed-by: kdnilsen, ysr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• d59effc: Use state of mark context itself to track stability of old mark bitmap
• 64d14f3: 8306334: Handle preemption of old cycle between filling and bootstrap phases
• badb738: Eliminate TODO in ShenandoahHeuristics::select_aged_regions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[earthling-amzn]

There are no new regressions here.

[ysramakrishna]

I have left a few comments. Despite the improvements that you have made by some of the current refactoring, I am concerned about the organization of the allocation paths and believe that there are opportunities for cleaning these up, and specializing and slimming these allocation paths a bit more.

That can wait for later, but I'd like to take another pass at this once you have had a chance to read the review comments and in case those lead to any changes.

Thanks!

[ysramakrishna]

I have left a few comments. Despite the improvements that you have made by some of the current refactoring, I am concerned about the organization of the allocation paths and believe that there are opportunities for cleaning these up, and specializing and slimming these allocation paths a bit more.

That can wait for later, but I'd like to take another pass at this once you have had a chance to read the review comments and in case those lead to any changes.

Thanks!

This is a good clean up, now that I see the big picture of the consolidation of the adjustments. I'll approve once you have had a chance to consider my review comments.

[earthling-amzn]

Thanks for the review @ysramakrishna . I'll make changes based on your suggestions.

[ysramakrishna]

Thanks for your patience with my review comments!

This looks good to me. 🚢

[earthling-amzn]

/integrate

[openjdk]

Going to push as commit d254fb2.
Since your change was applied there have been 3 commits pushed to the master branch:

• d59effc: Use state of mark context itself to track stability of old mark bitmap
• 64d14f3: 8306334: Handle preemption of old cycle between filling and bootstrap phases
• badb738: Eliminate TODO in ShenandoahHeuristics::select_aged_regions

Your commit was automatically rebased without conflicts.

[openjdk]

@earthling-amzn Pushed as commit d254fb2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.