-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase card offset mask #275
Increase card offset mask #275
Conversation
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
Webrevs
|
@earthling-amzn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit f969d53. |
@earthling-amzn Pushed as commit f969d53. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
On 32-bit platforms, a 512 byte card covers 128 words. On 64-bit platforms, a 1024 byte card (the maximum allowed) also covers 128 words. This change increases the size of the mask we use when encoding object start offsets to handle these situations.
Progress
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/275/head:pull/275
$ git checkout pull/275
Update a local copy of the PR:
$ git checkout pull/275
$ git pull https://git.openjdk.org/shenandoah.git pull/275/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 275
View PR using the GUI difftool:
$ git pr show -t 275
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/275.diff
Webrev
Link to Webrev Comment