Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8334491: GenShen: Revert changes to Shenandoah defaults #450

Conversation

earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented Jun 18, 2024

On the genshen branch, we have changed the adaptive heuristics decay factor to 0.1 and increased the learning cycles to 10. Testing with the original defaults of 0.5 and 5 (respectively) shows modest performance improvements in specjbb and extremem.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8334491: GenShen: Revert changes to Shenandoah defaults (Task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/450/head:pull/450
$ git checkout pull/450

Update a local copy of the PR:
$ git checkout pull/450
$ git pull https://git.openjdk.org/shenandoah.git pull/450/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 450

View PR using the GUI difftool:
$ git pr show -t 450

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/450.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 18, 2024

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 18, 2024

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334491: GenShen: Revert changes to Shenandoah defaults

Reviewed-by: kdnilsen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 343 new commits pushed to the master branch:

  • 2abf4cb: 8333750: GenShen: Only instantiate young/old generations in generational mode
  • e3c3098: 8333930: GenShen: Check for cancellation of old mark after final mark
  • 56611de: Merge
  • d8af589: 8026127: Deflater/Inflater documentation incomplete/misleading
  • 6238bc8: 8333456: CompactNumberFormat integer parsing fails when string has no suffix
  • 2a37764: 8333743: Change .jcheck/conf branches property to match valid branches
  • 75dc2f8: 8330182: Start of release updates for JDK 24
  • 054362a: 8332550: [macos] Voice Over: java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location
  • 9b436d0: 8333674: Disable CollectorPolicy.young_min_ergo_vm for PPC64
  • 487c477: 8333647: C2 SuperWord: some additional PopulateIndex tests
  • ... and 333 more: https://git.openjdk.org/shenandoah/compare/31bca3076634a3119a049283587dedd1c3de9f16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 18, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 18, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 18, 2024
@earthling-amzn
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 18, 2024

Going to push as commit 744fc26.
Since your change was applied there have been 343 commits pushed to the master branch:

  • 2abf4cb: 8333750: GenShen: Only instantiate young/old generations in generational mode
  • e3c3098: 8333930: GenShen: Check for cancellation of old mark after final mark
  • 56611de: Merge
  • d8af589: 8026127: Deflater/Inflater documentation incomplete/misleading
  • 6238bc8: 8333456: CompactNumberFormat integer parsing fails when string has no suffix
  • 2a37764: 8333743: Change .jcheck/conf branches property to match valid branches
  • 75dc2f8: 8330182: Start of release updates for JDK 24
  • 054362a: 8332550: [macos] Voice Over: java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location
  • 9b436d0: 8333674: Disable CollectorPolicy.young_min_ergo_vm for PPC64
  • 487c477: 8333647: C2 SuperWord: some additional PopulateIndex tests
  • ... and 333 more: https://git.openjdk.org/shenandoah/compare/31bca3076634a3119a049283587dedd1c3de9f16...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 18, 2024
@openjdk openjdk bot closed this Jun 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 18, 2024
@openjdk
Copy link

openjdk bot commented Jun 18, 2024

@earthling-amzn Pushed as commit 744fc26.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants