2039: Only post ApprovalNeededComment when the user hasn't applied for maintainer approval for all the issues

[zhaosongzs]

In SKARA-1949, we introduced /approval command and at the same time, we let the bot post ApprovalNeededComment when the pull request is reviewed.

As Kevin Rushforth suggested, the bot shouldn't post ApprovalNeededComment if the user already applied for all the issues.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace

Issue

• SKARA-2039: Only post ApprovalNeededComment when the user hasn't applied for maintainer approval for all the issues (Bug - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/skara.git pull/1606/head:pull/1606
$ git checkout pull/1606

Update a local copy of the PR:
$ git checkout pull/1606
$ git pull https://git.openjdk.org/skara.git pull/1606/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1606

View PR using the GUI difftool:
$ git pr show -t 1606

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/skara/pull/1606.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back zsong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (3291a323)
• 00: Full (39046995)

[kevinrushforth]

the bot shouldn't post ApprovalNeededComment if the user already applied for at least one of the issues.

For multiple issues, should the ApprovalNeededComment be posted if one (or more) of the issues is missing the approval request? In that case you would only skip posting the message if all of the issues have the approval request.

[zhaosongzs]

the bot shouldn't post ApprovalNeededComment if the user already applied for at least one of the issues.

For multiple issues, should the ApprovalNeededComment be posted if one (or more) of the issues is missing the approval request? In that case you would only skip posting the message if all of the issues have the approval request.

I was thinking post ApprovalNeededComment only when all the issues have the request, but later, I think that if there is one issue contains the request, then it means the user knows how to make the request. So no need to post the comment.

[erikj79]

the bot shouldn't post ApprovalNeededComment if the user already applied for at least one of the issues.

For multiple issues, should the ApprovalNeededComment be posted if one (or more) of the issues is missing the approval request? In that case you would only skip posting the message if all of the issues have the approval request.

I was thinking post ApprovalNeededComment only when all the issues have the request, but later, I think that if there is one issue contains the request, then it means the user knows how to make the request. So no need to post the comment.

I think I agree with Kevin. If any issue is missing the approval request, post the reminder. The user may have missed one unintentionally.

[zhaosongzs]

the bot shouldn't post ApprovalNeededComment if the user already applied for at least one of the issues.

For multiple issues, should the ApprovalNeededComment be posted if one (or more) of the issues is missing the approval request? In that case you would only skip posting the message if all of the issues have the approval request.

I was thinking post ApprovalNeededComment only when all the issues have the request, but later, I think that if there is one issue contains the request, then it means the user knows how to make the request. So no need to post the comment.

I think I agree with Kevin. If any issue is missing the approval request, post the reminder. The user may have missed one unintentionally.

OK, I will fix it.

[openjdk]

@zhaosongzs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

2039: Only post ApprovalNeededComment when the user hasn't applied for maintainer approval for all the issues

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• f300ab2: 2159: CheckRun repeats search for backport commit on each evaluation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[zhaosongzs]

Thanks for the review!
/integrate

[openjdk]

Going to push as commit 4e9dad2.
Since your change was applied there have been 2 commits pushed to the master branch:

• d8acf4d: 2160: Update GHA versions
• f300ab2: 2159: CheckRun repeats search for backport commit on each evaluation

Your commit was automatically rebased without conflicts.

[openjdk]

@zhaosongzs Pushed as commit 4e9dad2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.