-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8326990: [lworld] make value classes a preview feature #1037
8326990: [lworld] make value classes a preview feature #1037
Conversation
👋 Welcome back vromero! A progress list of the required criteria for merging this PR into |
@vicente-romero-oracle This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
/contributor add @fparain |
@vicente-romero-oracle |
/integrate |
Going to push as commit 9c21d4c.
Your commit was automatically rebased without conflicts. |
@vicente-romero-oracle Pushed as commit 9c21d4c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Javac changes to make value classes a preview feature,
TIA
Progress
Issue
Contributors
<fparain@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1037/head:pull/1037
$ git checkout pull/1037
Update a local copy of the PR:
$ git checkout pull/1037
$ git pull https://git.openjdk.org/valhalla.git pull/1037/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1037
View PR using the GUI difftool:
$ git pr show -t 1037
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1037.diff
Webrev
Link to Webrev Comment