Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326990: [lworld] make value classes a preview feature #1037

Closed

Conversation

vicente-romero-oracle
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Mar 7, 2024

Javac changes to make value classes a preview feature,

TIA


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8326990: [lworld] make value classes a preview feature (Bug - P4)

Contributors

  • Frederic Parain <fparain@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1037/head:pull/1037
$ git checkout pull/1037

Update a local copy of the PR:
$ git checkout pull/1037
$ git pull https://git.openjdk.org/valhalla.git pull/1037/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1037

View PR using the GUI difftool:
$ git pr show -t 1037

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1037.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2024

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326990: [lworld] make value classes a preview feature

Co-authored-by: Frederic Parain <fparain@openjdk.org>

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the lworld branch:

  • 676fe48: 8327498: [lworld] Remove Q-descriptor change from ASM and other clean up
  • 509b4ea: 8327253: [lworld] Preloading of classes needs a complete rework
  • d632066: 8327080: [lworld] Update Valhalla micros to JEP 401

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Mar 7, 2024

Webrevs

@vicente-romero-oracle
Copy link
Contributor Author

/contributor add @fparain

@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@vicente-romero-oracle
Contributor Frederic Parain <fparain@openjdk.org> successfully added.

@vicente-romero-oracle
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 8, 2024

Going to push as commit 9c21d4c.
Since your change was applied there have been 3 commits pushed to the lworld branch:

  • 676fe48: 8327498: [lworld] Remove Q-descriptor change from ASM and other clean up
  • 509b4ea: 8327253: [lworld] Preloading of classes needs a complete rework
  • d632066: 8327080: [lworld] Update Valhalla micros to JEP 401

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 8, 2024
@openjdk openjdk bot closed this Mar 8, 2024
@openjdk openjdk bot removed ready rfr labels Mar 8, 2024
@openjdk
Copy link

openjdk bot commented Mar 8, 2024

@vicente-romero-oracle Pushed as commit 9c21d4c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vicente-romero-oracle vicente-romero-oracle deleted the JDK-8326990 branch March 8, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant