Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327836: [lworld] update java/lang/invoke/VarHandles tests with preview feature enabled #1043

Closed
wants to merge 1 commit into from

Conversation

mlchung
Copy link
Member

@mlchung mlchung commented Mar 11, 2024

Update test/jdk/java/lang/invoke/VarHandles valhalla tests with @enablePreview


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8327836: [lworld] update java/lang/invoke/VarHandles tests with preview feature enabled (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1043/head:pull/1043
$ git checkout pull/1043

Update a local copy of the PR:
$ git checkout pull/1043
$ git pull https://git.openjdk.org/valhalla.git pull/1043/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1043

View PR using the GUI difftool:
$ git pr show -t 1043

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1043.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

…ew feature enabled
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2024

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327836: [lworld] update java/lang/invoke/VarHandles tests with preview feature enabled

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Mar 11, 2024

Webrevs

@mlchung
Copy link
Member Author

mlchung commented Mar 11, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 11, 2024

Going to push as commit 5973180.

@openjdk openjdk bot added the integrated label Mar 11, 2024
@openjdk openjdk bot closed this Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@mlchung Pushed as commit 5973180.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlchung mlchung deleted the JDK-8327836 branch April 3, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants