8334546: [lworld] C2: Calling clone() on non-allocated inline types fails with "Should have been buffered"

[chhagedorn]

We are currently not handling inline types in the clone() instrinsic because it was not possible for a value class to implement Cloneable. This changed with JDK-8332243. A value class now trivially returns the inline type because it has no identity. We need to do the same in the C2 intrinsic for clone() when we have an inline type (currently, we are hitting an assert later).

Thanks,
Christian

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8334546: [lworld] C2: Calling clone() on non-allocated inline types fails with "Should have been buffered" (Bug - P4)

Reviewers

• Tobias Hartmann (@TobiHartmann - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1149/head:pull/1149
$ git checkout pull/1149

Update a local copy of the PR:
$ git checkout pull/1149
$ git pull https://git.openjdk.org/valhalla.git pull/1149/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1149

View PR using the GUI difftool:
$ git pr show -t 1149

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1149.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334546: [lworld] C2: Calling clone() on non-allocated inline types fails with "Should have been buffered"

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the lworld branch:

• 76306cb: 8334692: [lworld] add missing compiler warnings
• 38f1e93: 8334747: [lworld] C1 needs adjustments after JDK-8294866
• 157a0a1: 8334729: [lworld] CDS should not force the computation of identity hash code for value instances
• 77bc8d3: 8334746: [lworld] GTestWrapper.java fails because of LogSelectionList
• 83b9474: 8294866: [lworld] Array classes access flags should include identity bits
• e183039: 8334678: [lworld] some javac tests are failing intermittently due to a VM warning
• e3da5c6: [lworld] Various fixes
• 404a4fa: 8333889: [lworld] C2: Hoisting speculative array access type check wrongly moves array access before its range check

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (bd1d725d)

[TobiHartmann]

Looks good to me!

[chhagedorn]

Thanks Tobias for your review!

/integrate

[openjdk]

@chhagedorn
Your change (at version bd1d725) is now ready to be sponsored by a Committer.

[TobiHartmann]

/sponsor

[openjdk]

Going to push as commit 09014c7.
Since your change was applied there have been 8 commits pushed to the lworld branch:

• 76306cb: 8334692: [lworld] add missing compiler warnings
• 38f1e93: 8334747: [lworld] C1 needs adjustments after JDK-8294866
• 157a0a1: 8334729: [lworld] CDS should not force the computation of identity hash code for value instances
• 77bc8d3: 8334746: [lworld] GTestWrapper.java fails because of LogSelectionList
• 83b9474: 8294866: [lworld] Array classes access flags should include identity bits
• e183039: 8334678: [lworld] some javac tests are failing intermittently due to a VM warning
• e3da5c6: [lworld] Various fixes
• 404a4fa: 8333889: [lworld] C2: Hoisting speculative array access type check wrongly moves array access before its range check

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann @chhagedorn Pushed as commit 09014c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.