8310023: [lworld] Implement alternative fast-locking scheme in Valhalla

[coleenp]

I don't see anything missing for implementing the test for inline types for lightweight locking. The only thing broken seems to be JNI monitorenter should throw IdentityException. I added some comments and asserts when I figured out the interpreter and c1/c2 don't get to ObjectSynchronizer::enter.
Tested with tier1 with LM_LIGHTWEIGHT as the default.

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8310023: [lworld] Implement alternative fast-locking scheme in Valhalla (Enhancement - P4)

Reviewers

• Frederic Parain (@fparain - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1158/head:pull/1158
$ git checkout pull/1158

Update a local copy of the PR:
$ git checkout pull/1158
$ git pull https://git.openjdk.org/valhalla.git pull/1158/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1158

View PR using the GUI difftool:
$ git pr show -t 1158

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1158.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310023: [lworld] Implement alternative fast-locking scheme in Valhalla

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the lworld branch:

• 817c24a: 8335772: [lworld] fix for JDK-8335641 should have added some classes to GensrcValueClasses.gmk
• 9e829b8: 8310655: [lworld] ShouldNotReachHere() error in ObjectSynchronizer::FastHashCode
• 555a3ff: 8335796: [lworld] several refactorins and bug fixes
• d0133cd: 8335770: [lworld] improve javap code coverage

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@fparain) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 01: Full - Incremental (c889826e)
• 00: Full (93e487e7)

[fparain]

JNI's MonitorEnter issue has a proposed fixed in #1160

[openjdk]

@coleenp Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[coleenp]

Thanks for pointing out your PR. I don't get notification for these.

[coleenp]

Thanks for reviewing, Fred.
/integrate

[openjdk]

@coleenp
Your change (at version c889826) is now ready to be sponsored by a Committer.

[fparain]

/sponsor

[openjdk]

Going to push as commit ad13f8d.
Since your change was applied there have been 4 commits pushed to the lworld branch:

• 817c24a: 8335772: [lworld] fix for JDK-8335641 should have added some classes to GensrcValueClasses.gmk
• 9e829b8: 8310655: [lworld] ShouldNotReachHere() error in ObjectSynchronizer::FastHashCode
• 555a3ff: 8335796: [lworld] several refactorins and bug fixes
• d0133cd: 8335770: [lworld] improve javap code coverage

Your commit was automatically rebased without conflicts.

[openjdk]

@fparain @coleenp Pushed as commit ad13f8d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.