Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338698: [lworld] ObjectStreamClass should throw InstantiationException for abstract value class #1215

Closed

Conversation

RogerRiggs
Copy link
Collaborator

@RogerRiggs RogerRiggs commented Aug 21, 2024

Updated ObjectStreamClass creation of newValueInstance to throw InstantiationException if the class is abstract or identity class.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8338698: [lworld] ObjectStreamClass should throw InstantiationException for abstract value class (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1215/head:pull/1215
$ git checkout pull/1215

Update a local copy of the PR:
$ git checkout pull/1215
$ git pull https://git.openjdk.org/valhalla.git pull/1215/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1215

View PR using the GUI difftool:
$ git pr show -t 1215

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1215.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

…on for abstract value class

Updated ObjectStreamClass creation of newValueInstance to throw InstantiationException
if the class is abstract or identity class.
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2024

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 21, 2024

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338698: [lworld] ObjectStreamClass should throw InstantiationException for abstract value class

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Aug 21, 2024

Webrevs

@RogerRiggs
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 21, 2024

Going to push as commit b81cb4e.

@openjdk openjdk bot added the integrated label Aug 21, 2024
@openjdk openjdk bot closed this Aug 21, 2024
@openjdk
Copy link

openjdk bot commented Aug 21, 2024

@RogerRiggs Pushed as commit b81cb4e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant