Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8351432: [lworld] Update nsk/jvmti/GetObjectMonitorUsage/objmonusage007.java to don't faile with compilation error #1391

Closed
wants to merge 2 commits into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Mar 7, 2025

The test is fixed to don't build itself code as a library


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8351432: [lworld] Update nsk/jvmti/GetObjectMonitorUsage/objmonusage007.java to don't faile with compilation error (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1391/head:pull/1391
$ git checkout pull/1391

Update a local copy of the PR:
$ git checkout pull/1391
$ git pull https://git.openjdk.org/valhalla.git pull/1391/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1391

View PR using the GUI difftool:
$ git pr show -t 1391

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1391.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

…07.java to don't faile with compilation error
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2025

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 7, 2025

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351432: [lworld] Update nsk/jvmti/GetObjectMonitorUsage/objmonusage007.java to don't faile with compilation error

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RogerRiggs) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

mlbridge bot commented Mar 7, 2025

Webrevs

Copy link
Collaborator

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For simple change for which you are confident, there's not need to wait for a review.
It is useful to allow enough time for people to response or comment.

@lmesnik
Copy link
Member Author

lmesnik commented Mar 7, 2025

@RogerRiggs Thanks for explanation and review.
/integrate

@openjdk openjdk bot added the sponsor label Mar 7, 2025
@openjdk
Copy link

openjdk bot commented Mar 7, 2025

@lmesnik
Your change (at version c13295f) is now ready to be sponsored by a Committer.

@MrSimms
Copy link
Member

MrSimms commented Mar 10, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 10, 2025

Going to push as commit 82a5d5d.

@openjdk
Copy link

openjdk bot commented Mar 10, 2025

@MrSimms @lmesnik Pushed as commit 82a5d5d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants