8304168: [lworld] CDS tests fail with --enable-preview patched value classes

[RogerRiggs]

When --enable-preview is true, the patching of some java.base classes as value classes disables CDS.
Subsequently the CDS tests fail.

For a CDS, disable Valhalla when --enable-preview is set so java.base is not patched with value classes.

---

Progress

• Change must not contain extraneous whitespace

Integration blocker

 ⚠️ Whitespace errors (failed with the updated jcheck configuration)

Issue

• JDK-8304168: [lworld] CDS tests fail with --enable-preview patched value classes (Bug - P4)

Reviewers

• Tobias Hartmann (@TobiHartmann - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/832/head:pull/832
$ git checkout pull/832

Update a local copy of the PR:
$ git checkout pull/832
$ git pull https://git.openjdk.org/valhalla.git pull/832/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 832

View PR using the GUI difftool:
$ git pr show -t 832

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/832.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (787b4456)
• 00: Full (f735b665)

[mlchung]

Is this just a temporary fix? We would need debugging to work with --enable-preview. For CDS, is it possible to have an alternative shared archive with the value classes and special case for --enable-preview?

[openjdk]

@RogerRiggs This change is no longer ready for integration - check the PR body for details.

[RogerRiggs]

Is this just a temporary fix? We would need debugging to work with --enable-preview. For CDS, is it possible to have an alternative shared archive with the value classes and special case for --enable-preview?

Temporary in the sense that until value classes are fully integrated, some mechanism is needed to include them when --enable-preview or not. And that optionality will need to work with CDS in some yet to be determined fashion.

[RogerRiggs]

The test failures in jdi are not due to --enable-preview, for now only address the cds test failure.

[mlchung]

I think it may be better to problem list this test and create a JBS issue to follow up how CDS works with --enable-preview (that currently translates into --patch-module options).

[TobiHartmann]

Looks reasonable to me.

[TobiHartmann]

Problem listing sounds good as well. This just causes lots of noise in testing in the CI so it would be nice to get a fix in soon.

[openjdk]

@RogerRiggs this pull request can not be integrated into lworld due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8304168-cds-test-fails
git fetch https://git.openjdk.org/valhalla.git lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push

[bridgekeeper]

@RogerRiggs This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@RogerRiggs This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.