Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge lworld #985

Conversation

vicente-romero-oracle
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Jan 31, 2024

Merge branch 'lworld' into jep_401_javac_merge_lworld


Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/985/head:pull/985
$ git checkout pull/985

Update a local copy of the PR:
$ git checkout pull/985
$ git pull https://git.openjdk.org/valhalla.git pull/985/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 985

View PR using the GUI difftool:
$ git pr show -t 985

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/985.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

mcimadamore and others added 30 commits October 18, 2023 17:02

Verified

This commit was signed with the committer’s verified signature.
IvanGoncharov Ivan Goncharov
Reviewed-by: iris

Verified

This commit was signed with the committer’s verified signature.
IvanGoncharov Ivan Goncharov
Reviewed-by: iklam

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Reviewed-by: rriggs, joehw, lancea, erikj, iris, ihse

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Reviewed-by: lmesnik
…erImpl.Element._Depth

Reviewed-by: lancea, joehw
…xchg result

Reviewed-by: thartmann, kvn, aph
Reviewed-by: pchilanomate, eosterlund
…r comparison of improvements

Reviewed-by: gziemski, ihse
aivanov-jdk and others added 16 commits October 25, 2023 11:31
…correct when running on MSYS2

Reviewed-by: ihse, erikj
…ning

Co-authored-by: Emanuel Peter <epeter@openjdk.org>
Reviewed-by: thartmann, epeter
…l initialization routines

Reviewed-by: shade, egahlin
…o when an executable and a library share the same name

Reviewed-by: ihse, erikj
Merge jdk-22+21
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 31, 2024

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into jep_401_javac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 31, 2024

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Merge lworld

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jep_401_javac branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jep_401_javac branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Jan 31, 2024

@vicente-romero-oracle
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 31, 2024

Going to push as commit c400ce3.

@openjdk openjdk bot added the integrated label Jan 31, 2024
@openjdk openjdk bot closed this Jan 31, 2024
@openjdk
Copy link

openjdk bot commented Jan 31, 2024

@vicente-romero-oracle Pushed as commit c400ce3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vicente-romero-oracle vicente-romero-oracle deleted the jep_401_javac_merge_lworld branch January 31, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet